Add RHEL support and include Linux distro in cache keys#1323
Open
priyagupta108 wants to merge 5 commits into
Open
Add RHEL support and include Linux distro in cache keys#1323priyagupta108 wants to merge 5 commits into
priyagupta108 wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds RHEL-aware Python release resolution and standardizes Linux cache keys by incorporating Linux distro name + version across pip/pipenv/poetry (while keeping Windows/macOS keys unchanged).
Changes:
- Add RHEL-specific manifest filtering during Python version resolution.
- Add a shared
getLinuxInfoKeySegment()helper and use it to include Linux distro info in pip/pipenv/poetry cache keys. - Make Linux distro detection more resilient by falling back from
lsb_releaseto/etc/os-release.
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils.ts | Adds fallback Linux distro detection via /etc/os-release when lsb_release fails. |
| src/install-python.ts | Adds RHEL detection and custom manifest matching for platform: rhel. |
| src/cache-distributions/cache-distributor.ts | Introduces shared Linux distro cache-key segment helper (incl. RHEL major-version logic). |
| src/cache-distributions/pip-cache.ts | Switches pip cache keys to use the shared Linux distro key segment helper. |
| src/cache-distributions/pipenv-cache.ts | Adds Linux distro segment to pipenv cache keys via shared helper. |
| src/cache-distributions/poetry-cache.ts | Adds Linux distro segment to poetry cache keys via shared helper. |
| dist/setup/index.js | Regenerated bundled output reflecting the source changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
priya-kinthali
previously approved these changes
Jun 17, 2026
… improved reliability
priya-kinthali
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Impact:
One-time cache regeneration for Linux pipenv/poetry users on the first run. Windows and macOS keys are unchanged.
Check list: